[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/4] ocaml: Don't include guestfs-internal.h directly.



On Wed, Jan 18, 2012 at 04:29:47PM +0100, Jim Meyering wrote:
> Richard W.M. Jones wrote:
> > From: "Richard W.M. Jones" <rjones redhat com>
> >
> > However since the OCaml bindings use guestfs_safe_strdup we need to
> > export that (in the private functions section) from guestfs.h.
> 
> And guestfs_safe_memdup, obviously.

Yes, I forgot to mention that in the commit message, but I'll
reword it.

> I presume this was motivated by the scope-limiting change?
> Nice fall-out.

Yes, it was a consequence of changing the visibility.

I've also checked, and src/guestfs-internal.h is not included anywhere
else.  It really should not have been included by the OCaml bindings,
but no harm done.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]