[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] CamelName patch

On 01/19/2012 08:43 PM, Richard W.M. Jones wrote:
I don't remember this commit coming up for review, although it seems
to have been pushed upstream:

Well spotted! I was just about to point out that you did review it, when I noticed I'd mixed this one up with a similar one. You reviewed the other one. I have pushed this one accidentally.

commit 83c20f02dc0e97b098e9de837839a3f4a4416129
Author: Matthew Booth<mbooth redhat com>
Date:   Fri Jan 13 10:00:30 2012 +0000

     generator: Add CamelName flag

     We can make a good guess at camel case names for most APIs. For example,
     add_drive_opts can be automatically transformed to AddDriveOpts. However, ot
     apis don't produce a satisfactory name when transformed automatically. For
     example, we would want md_create to produce MDCreate rather than MdCreate.

     This change adds a CamelName flag which allows a camel case name to be speci
     explicitly when the automatic transformation isn't satisfactory.

It seems to have a couple of problems: firstly it would change the
Java bindings.  In fact it doesn't do that because (secondly) the
CamelName flag has no effect.

You're right that it has no effect. It should have been part of the gobject series, which does use it.

Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]