[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/7] Replace setting of environment variables with usage of local run script



On Fri, Jan 20, 2012 at 08:44:43AM +0100, Hilko Bengen wrote:
> ---
>  align/Makefile.am             |    4 +---
>  cat/Makefile.am               |    4 +---
>  clone/Makefile.am             |    4 +---
>  df/Makefile.am                |    4 +---
>  edit/Makefile.am              |    4 +---
>  fish/Makefile.am              |    4 +---
>  haskell/Makefile.am           |    6 ++----
>  ocaml/Makefile.am             |    6 ++----
>  perl/Makefile.am              |    4 +---
>  resize/Makefile.am            |    4 +---
>  ruby/Makefile.am              |    6 ++----
>  sparsify/Makefile.am          |    4 +---
>  tests/luks/Makefile.am        |    4 +---
>  tests/lvm/Makefile.am         |    5 +----
>  tests/md/Makefile.am          |    4 +---
>  tests/protocol/Makefile.am    |    5 +----
>  tests/qemu/Makefile.am        |    4 +---
>  tests/regressions/Makefile.am |    5 +----
>  tools/Makefile.am             |    5 +----
>  19 files changed, 22 insertions(+), 64 deletions(-)

In principle yes, but there's a problem with this patch:

>  TESTS_ENVIRONMENT = \
> -	LD_LIBRARY_PATH=$(top_builddir)/src/.libs \
> -	LIBGUESTFS_PATH=$(top_builddir)/appliance \
> -	TMPDIR=$(top_builddir) \
> -	$(VG)
> +	$(VG) \
> +	$(top_builddir)/run

This will cause valgrind to check bash.  It need to be the other
way around:

> -	$(VG)
> +	$(top_builddir)/run \
> +	$(VG)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]