[Libguestfs] [PATCH V2 4/4] umount: use Dev_or_Path instead of untype

[Wanlong Gao]

On 07/23/2012 04:16 PM, Richard W.M. Jones wrote:
> On Mon, Jul 23, 2012 at 11:43:23AM +0800, Wanlong Gao wrote:
>> Use Dev_or_Path type for device or path arguments.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com>
>> ---
>>  generator/generator_actions.ml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/generator/generator_actions.ml b/generator/generator_actions.ml
>> index da01d7e..ca9e078 100644
>> --- a/generator/generator_actions.ml
>> +++ b/generator/generator_actions.ml
>> @@ -2749,7 +2749,7 @@ characters does I<not> work, even if the length is specified." };
>>  
>>    { defaults with
>>      name = "umount";
>> -    style = RErr, [String "pathordevice"], [OBool "force"; OBool "laze"];
>> +    style = RErr, [Dev_or_Path "pathordevice"], [OBool "force"; OBool "laze"];
> 
> Does this actually work?  The do_umount function still calls
> RESOLVE_DEVICE, so this would now be done twice.

Yes, it works, double resolve device is harmless.


Thanks,
Wanlong Gao

> 
> Have a look at daemon/stubs.c to see what code is being generated.
> 
> Rich.
>