[Libguestfs] [PATCH V3 2/2] xfs_info: resolve device when doing xfs_info on a device

Wanlong Gao gaowanlong at cn.fujitsu.com
Tue Jul 24 08:33:46 UTC 2012


On 07/24/2012 04:32 PM, Richard W.M. Jones wrote:
> On Mon, Jul 23, 2012 at 05:51:32PM +0800, Wanlong Gao wrote:
>> -    style = RStruct ("info", "xfsinfo"), [Pathname "path"], [];
>> +    style = RStruct ("info", "xfsinfo"), [String "pathordevice"], [];
> 
> Actually NACK to this.  I don't understand why you don't
> use Dev_or_Path here.

Dev_or_Path generates RESOLVE_DEVICE code in stubs.c, then
it does RESOLVE_DEVICE twice, right?

Thanks,
Wanlong Gao

> 
> Rich.
> 




More information about the Libguestfs mailing list