[Libguestfs] [PATCH V2] virt-sysprep:add ipconfig for preparation

[Richard W.M. Jones]

On Sun, Mar 11, 2012 at 07:06:32PM +0800, Wanlong Gao wrote:
> On 03/09/2012 11:48 PM, Richard W.M. Jones wrote:
> 
> > On Fri, Mar 09, 2012 at 02:50:17PM +0800, Wanlong Gao wrote:
> >> +#FIXME: This may not work OK for IPv6 ?
> > 
> > :-)
> > Does it work or not?  Anyone??
> 
> 
> The "enable=ipconfig" can work but "--ipconfig" here can't work on IPv6
> because the  IPv6 address's format is "XXXX:XXXX:...", so we can add the
> IPv6 part if it needed future.

> >> +                        __device=$(echo "$ipconfig_param" | awk -v j=$i -F: '{print $j}')

Isn't it a problem that we are splitting on the ':' character?
I mean, for a future IPv6 version?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org