[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 07/16] gobject: Add basic gtk-doc for properties



On Tue, Mar 27, 2012 at 04:00:49PM +0100, Matthew Booth wrote:
> ---
>  generator/generator_gobject.ml |   37 ++++++++++++++++++++++---------------
>  1 files changed, 22 insertions(+), 15 deletions(-)
> 
> diff --git a/generator/generator_gobject.ml b/generator/generator_gobject.ml
> index c1eb6c0..017e860 100644
[...]
> +      let (type_spec, type_init, type_desc) = (match optargt with

You don't need the parens around the return values, nor the parens
around match.  A more natural way to write this is:

  let type_spec, type_init, type_desc =
    match optargt with
    | OBool n ->
      (* etc. etc. *)
      (* last line *) in

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]