[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] lib: Add inspect_list_applications2 method (RHBZ#859949)

On Thu, Nov 01, 2012 at 12:17:25PM -0400, John Eckersberg wrote:
> +I<This call is deprecated>; use C<guestfs_inspect_list_applications2> instead.

Don't do this.  The generator has a deprecated_by field which does the
right thing.  You don't need to change the documentation for the
deprecated function at all.

> +  (* Application v2. *)
> +  { defaults with
> +    s_name = "application2";
> +    s_cols = [
> +    "app_name", FString;

Unfortunately I think you'll have to name the fields app2_*.  The
reason is that the OCaml bindings won't work where you've got multiple
fields in different structs with the same name (the generator ought to
check for this and give an error, but obviously it's not doing that).

> --- a/src/inspect-apps.c
> +++ b/src/inspect-apps.c
> +struct guestfs_application_list*

Space before the '*' character.

The rest of the patch looks fine.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]