[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 0/1] lib: debian support for package arch inspection

On Mon, Nov 05, 2012 at 10:16:35AM -0500, John Eckersberg wrote:
> This adds package arch inspection for deb-based systems.  The patch
> returns package arch as given by dpkg, which means that it returns
> 'amd64' instead of 'x86_64', for example.  Whether or not we should
> standardize this to match rpm output is up for debate.  I see other
> places such as guestfs_file_architecture that use the rpm-style arch.
> I can understand though where a user of guestfs inspecting deb-based
> hosts would rather get back the "native" strings.

Thanks, ACKed and pushed.

I tend to agree with your decision to keep the native string, for the
following reasons:

 - any attempt by libguestfs to rewrite these arch strings is
   prone to go wrong for unexpected reasons

 - avoids losing information

 - the strings are not well-standardized anyway (eg. i386 vs i686)
   so the caller may still want to do their own canonicalization


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]