[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 7/7] Add extra field(s) to guestfs_application struct.



On Tue, Oct 30, 2012 at 11:57:15AM +0000, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones redhat com>
> 
> This breaks the ABI, but by using symbol versioning existing callers
> will not be affected.  Also this change is source compatible, so
> existing code does not need to be modified.

Personally I wouldn't do this, I'd add a new API using the new
ABI, leaving the original APIs intact. While I think symbol
versioning is good in general, I'm not a fan of using it for
hiding ABI breakage. Be aware that while many UNIX have symbol
versioning, most do not allow for replacement of symbols with
the same name. This was a Linux enhancement over the original
Solaris scheme. So making use of this feature will mean you
will suffer ABI breakage on any non-Linux platform.

Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]