[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH V1] NEW API:ext:mke2fs



On Mon, Sep 03, 2012 at 11:44:15AM +0800, Wanlong Gao wrote:
> On 08/31/2012 06:00 PM, Wanlong Gao wrote:
> > New api mke2fs for full configuration of filesystem.
> > 
> > Signed-off-by: Wanlong Gao <gaowanlong cn fujitsu com>
> > ---
> >  daemon/ext2.c                  | 452 +++++++++++++++++++++++++++++++++++++++++
> >  generator/generator_actions.ml |  18 ++
> >  gobject/Makefile.inc           |   6 +-
> >  src/MAX_PROC_NR                |   2 +-
> >  4 files changed, 475 insertions(+), 3 deletions(-)
> 
> Hi Rich,
> 
> I got the following error when compiling with this patch, it seems that the
> long typed optargs_bitmask can't accept more than 31 optional arguments, it's
> odd ?  This mke2fs api has about 43 optional arguments, so 64bit typed optargs_bitmask
> is enough, but why does long type limit the arguments to 31?
> 
> ./com/redhat/et/libguestfs/GuestFS.java:14731: error: integer number too large: 2147483648
>       _optargs_bitmask |= 2147483648;

I fixed this and added a test, thanks:

https://github.com/libguestfs/libguestfs/commit/f65dee769d1fc53c5963c381bf8a1bf02654f78c
https://github.com/libguestfs/libguestfs/commit/3820a2578c120056683a4b152b72021f82b2c821

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]