[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH V3] NEW API:ext:mke2fs



On 09/17/2012 03:12 PM, Richard W.M. Jones wrote:
> On Mon, Sep 17, 2012 at 02:39:17PM +0800, Wanlong Gao wrote:
>> > On 09/11/2012 08:53 PM, Wanlong Gao wrote:
>>> > > New api mke2fs for full configuration of filesystem.
>> > 
>> > Hi Rich, 
>> > 
>> > I fixed as your comments, but see this error,
>> > "Fatal error: exception Failure("function mke2journal has tests but does not test itself") "
>> > 
>> > How should I fix this problem ?
> This means that the mke2journal test doesn't test the mke2journal
> function.  That's because you shouldn't change the tests of the
> deprecated functions (mke2journal etc).  Leave them alone.  But you
> should copy those tests into mke2fs, changing them to use mke2fs
> (which you did, but only partially).

OK, got it. Thank you.

> 
>> > And can you review the other parts?
> Sure, later (today hopefully).
> 

OK.

Thanks,
Wanlong Gao


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]