[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] sysprep: handle SuSE in hostname operation



On Wed, Sep 19, 2012 at 08:08:39PM +0200, Olaf Hering wrote:
> On Wed, Sep 19, Richard W.M. Jones wrote:
> 
> > On Wed, Sep 19, 2012 at 07:26:21PM +0200, Olaf Hering wrote:
> > > On Wed, Sep 19, Richard W.M. Jones wrote:
> > > 
> > > > I should add here this would require us to detect "sles".  I'm
> > > > not sure what SLES guests return right now, it could be "opensuse",
> > > > but I don't have a guest to test with.
> > > 
> > > Right now its still opensuse because the code just matches
> > > /etc/SuSE-release
> > 
> > We should probably differentiate between "opensuse" and "sles",
> > as we currently do with the various Fedora/RHEL/derivatives.
> 
> Looking at this, the code could detect 'opensuse', 'sle' (to catch SLES,
> SLED and SLERT), and suse_based.

For "sle" (ugly - better to just call it "sles"?), note there's a
subfield (guestfs_inspect_get_product_variant) that could be used to
differentiate between server/desktop/realtime variants.

One day I intend to implement this for RHEL (ie. RHEL Desktop vs
Server).  However currently that field only returns useful information
for Windows guests ("Client" or "Server" in that case).  It is used in
virt-v2v to differentiate between Windows 7 and its server equivalent
(Win2008 IIRC) which are otherwise identical.

It's a nice to have if you want to implement it, but not necessary.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]