[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 1/2] Fix bogus partition number passed to guestfs___check_for_filesystem_on



On Fri, 2013-02-08 at 09:44 +0000, Richard W.M. Jones wrote:
> This patch moves a lot of variable declarations inline.  I've
> been steadily moving them to the top of function definitions ...

Then I've been steadily moving them back again :) You need a policy on
this. In general, though, it is best practise to minimise the scope of a
variable. This includes declaring it close to use.

Matt


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]