[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] New internal API: internal_parse_mountable



On Tue, Feb 12, 2013 at 03:31:38PM +0000, Matthew Booth wrote:
> +test_internal_parse_mountable_SOURCES = test-internal-parse-mountable.c
> +test_internal_parse_mountable_CFLAGS = \
> +	-DGUESTFS_WARN_DEPRECATED=1 \
> +	-DGUESTFS_PRIVATE=1 \
> +	-I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \
> +	-I$(top_srcdir)/src -I$(top_builddir)/src \
> +	$(WARN_CFLAGS) $(WERROR_CFLAGS) \
> +	$(GPROF_CFLAGS) $(GCOV_CFLAGS)

It's apparently better to write this as:

test_internal_parse_mountable_CPPFLAGS = \
	-DGUESTFS_WARN_DEPRECATED=1 \
	-DGUESTFS_PRIVATE=1 \
	-I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \
	-I$(top_srcdir)/src -I$(top_builddir)/src
test_internal_parse_mountable_CFLAGS = \
	$(WARN_CFLAGS) $(WERROR_CFLAGS) \
	$(GPROF_CFLAGS) $(GCOV_CFLAGS)

...

ACK, this all looks good now.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]