[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 3/4] ruby: remove non-template extconf.rb; don't compile with -Werror.



On Mon, Feb 18, 2013 at 10:43:42PM +0100, Hilko Bengen wrote:
> Otherwise, _guestfs.c can't be compiled due to many strict-prototype
> warnings turned into errors:
>
> compiling /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/../..
> /ruby/ext/guestfs/_guestfs.c
> In file included from /usr/include/ruby-1.9.1/ruby.h:32:0,
>                  from /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-d
> efault/../../ruby/ext/guestfs/_guestfs.c:29:
> /usr/include/ruby-1.9.1/ruby/ruby.h:1093:1: error: function declaration isn’t a
> prototype [-Werror=strict-prototypes]

I think it's probably better to compile without --enable-gcc-warnings.
In the Fedora package we don't use that option.  I only use it on my
local machine.

Unless this error still happens even without that option?

> [...]

This hunk seems separate (for separate src/build dir?), and looks OK
to me:

>  create_header
> -create_makefile(extension_name)
> +create_makefile(extension_name, "@abs_srcdir@")
> -- 
> 1.7.10.4

RIch.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]