[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] Add read support for "big data" blocks to hivex



* Richard W.M. Jones:

> diff --git a/lib/hivex.c b/lib/hivex.c
> index e3c1e05..9351ac5 100644
> --- a/lib/hivex.c
> +++ b/lib/hivex.c
> @@ -1471,7 +1471,7 @@ hivex_value_value (hive_h *h, hive_value_h value,
>          if (h->msglvl >= 2)
>            fprintf (stderr, "hivex_value_value: warning: big data block is not "
>                     "valid (db block 0x%zx, block list 0x%zx, data block 0x%zx)\
> -                   data_offset, blocklist_offset, subblock_offset);
> +                   data_offset, blocklist_offset, (size_t) subblock_offset);
>        }
>        int32_t seg_len = block_len(h, subblock_offset, NULL);
>        struct ntreg_db_block *subblock =
>
> to make it compile without warnings.

Yeah, so I'll just make subblock_offset a size_t, like all the other
offset values.

> With that addition, * ACK *.

I'll post a slightly updated version, with better error messages, just
to be sure.

Cheers,
-Hilko


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]