[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] Fixes from the patch queue of the Debian package

On Thu, Mar 07, 2013 at 07:59:24PM +0100, Hilko Bengen wrote:
> Here are three patches that fix issues with out-of-tree building and
> one that uses Ruby's own autoconf stuff for determining how Ruby
> bindings should be built.

Thanks for posting these, and if Debian are maintaining any
out-of-tree patches that you think should go upstream, please post
them any time you like!

3/4 looks like a hack, so I didn't apply that.

2/4 gives me this failure:

_guestfs.c: In function 'rb_hash_lookup':
_guestfs.c:76:30: error: 'struct RHash' has no member named 'tbl'
_guestfs.c:76:19: error: passing argument 3 of 'st_lookup' discards 'volatile' qualifier from pointer target type [-Werror]
In file included from /usr/include/ruby/intern.h:34:0,
                 from /usr/include/ruby/ruby.h:1382,
                 from /usr/include/ruby.h:32,
                 from _guestfs.c:31:
/usr/include/ruby/st.h:114:5: note: expected 'st_data_t *' but argument is of type 'volatile VALUE *'
cc1: all warnings being treated as errors
make[3]: *** [_guestfs.o] Error 1

However I have applied and will shortly push the other two.

Thanks again,


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]