[Libguestfs] [PATCH] daemon: parted: part-get-name: switch from sgdisk to parted (RHBZ#1088424).

[Richard W.M. Jones]

On Thu, Apr 17, 2014 at 11:38:27AM +0200, Pino Toscano wrote:
> Use parted to get the name of partitions in GPT layouts instead of
> sgdisk, to reduce the possible discrepancy between output of tools.
> 
> The actual case here is that recent parted versions fixed/improved their
> UTF-16 handling of partition names in GPT, and sgdisk seems to not be
> properly handling them, returning also unicode control bytes.
> Since parted can provide partition names already, just make use of it.
> 
> Since sgdisk is no more needed for part_get_name, the function is no
> more optional on it.
> ---
>  daemon/parted.c      | 80 ++++++++++++++++++++++++++++++++++++----------------
>  generator/actions.ml |  1 -
>  2 files changed, 55 insertions(+), 26 deletions(-)

ACK.

Be nicer if it came with a test (but perhaps test-virt-resize is enough!)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top