[Libguestfs] [PATCH 06/13] fish: edit: improve the editor execution

Richard W.M. Jones rjones at redhat.com
Thu Aug 28 18:36:20 UTC 2014


On Thu, Aug 28, 2014 at 03:21:09PM +0200, Pino Toscano wrote:
>    /* Edit it. */
> -  /* XXX Safe? */
> -  snprintf (buf, sizeof buf, "%s %s", editor, filename);
> +  if (asprintf (&cmd, "%s %s", editor, tmpfilename) == -1) {

filename -> tmpfilename.  Is that right?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list