[Libguestfs] [PATCH 06/13] fish: edit: improve the editor execution

Pino Toscano ptoscano at redhat.com
Fri Aug 29 08:45:58 UTC 2014


On Thursday 28 August 2014 19:36:20 Richard W.M. Jones wrote:
> On Thu, Aug 28, 2014 at 03:21:09PM +0200, Pino Toscano wrote:
> >    /* Edit it. */
> > 
> > -  /* XXX Safe? */
> > -  snprintf (buf, sizeof buf, "%s %s", editor, filename);
> > +  if (asprintf (&cmd, "%s %s", editor, tmpfilename) == -1) {
> 
> filename -> tmpfilename.  Is that right?

This commit is "right" actually, what is wrong is the previous commit 
which apparently was an old version missing that rename (slipped through 
the refactoring of the refactoring...).

Previous commit fixed, thanks.

-- 
Pino Toscano




More information about the Libguestfs mailing list