[Libguestfs] [PATCH 1/2] php: make the test suite failures fatal

Pino Toscano ptoscano at redhat.com
Tue Mar 18 14:15:16 UTC 2014


So far the failure of some test would have not reported a non-zero
return value by run-tests.php. Since now all the PHP tests pass, we can
ask for failures to be fatal, by exporting REPORT_EXIT_STATUS=1 for
run-tests.php.
---
 php/run-php-tests.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/php/run-php-tests.sh b/php/run-php-tests.sh
index 6f9ae10..e498987 100755
--- a/php/run-php-tests.sh
+++ b/php/run-php-tests.sh
@@ -44,5 +44,4 @@ printenv | grep -E '^(LIBGUESTFS|LIBVIRT|LIBVIRTD|VIRTLOCKD|LD|MALLOC)_' >> env
 TESTS=$(echo guestfs_php_*.phpt)
 echo TESTS: $TESTS
 
-# PHP ignores the result of the tests!
-make test TESTS="$TESTS" PHP_EXECUTABLE="$PWD/php-for-tests.sh"
+make test TESTS="$TESTS" PHP_EXECUTABLE="$PWD/php-for-tests.sh" REPORT_EXIT_STATUS=1
-- 
1.8.3.1




More information about the Libguestfs mailing list