[Libguestfs] [PATCH] builder: allow to run website tests under valgrind

Richard W.M. Jones rjones at redhat.com
Thu Mar 20 15:32:42 UTC 2014


On Thu, Mar 20, 2014 at 04:25:07PM +0100, Pino Toscano wrote:
> ---
>  builder/website/Makefile.am | 3 +++
>  builder/website/validate.sh | 4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/builder/website/Makefile.am b/builder/website/Makefile.am
> index a5b1bcf..6b609f6 100644
> --- a/builder/website/Makefile.am
> +++ b/builder/website/Makefile.am
> @@ -45,3 +45,6 @@ CLEANFILES = *~
>  # Validates the index file.
>  TESTS_ENVIRONMENT = $(top_builddir)/run --test
>  TESTS = validate.sh
> +
> +check-valgrind:
> +	$(MAKE) VG="$(top_builddir)/run @VG@" check
> diff --git a/builder/website/validate.sh b/builder/website/validate.sh
> index 1c535e7..bd9a4ed 100755
> --- a/builder/website/validate.sh
> +++ b/builder/website/validate.sh
> @@ -19,6 +19,6 @@
>  export LANG=C
>  set -e
>  
> -../virt-index-validate $srcdir/index
> -../virt-index-validate $srcdir/index.asc
> +$VG ../virt-index-validate $srcdir/index
> +$VG ../virt-index-validate $srcdir/index.asc

ACK.

I'm slightly surprised that virt-builder isn't being run under valgrind :-(

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list