[Libguestfs] [PATCH 1/4] generator: add always-available optgroups

[Pino Toscano]

On Tuesday 20 May 2014 21:40:21 Richard W.M. Jones wrote:
> On Tue, May 20, 2014 at 07:54:45PM +0200, Pino Toscano wrote:
> > Support the possibility to have optional groups always enabled (e.g.
> > because they were present in the past, and they need to be kept for
> > users).
> > Add and use few helper optgroups-related functions to deal also with
> > them.
> 
> What do you think about the attached addition to this patch?

 let optgroups_names_all =
-  List.sort compare (optgroups_names @ optgroups_available)
+  List.sort compare (optgroups_names @ optgroups_retired)

Wouldn't this give duplicate values if a feature appears in both 
internal_optgroups_available/optgroups_retired and the auto-generated 
optgroups_names?

-- 
Pino Toscano