[Libguestfs] [PATCH] generator: fix daemon functions with optional params but no mandatory params

Pino Toscano ptoscano at redhat.com
Thu May 29 08:49:57 UTC 2014


The
  struct guestfs_$function_args args;
declaration was not emitted in that case, leading to build failure.
---
 generator/c.ml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/generator/c.ml b/generator/c.ml
index ee276dc..1fa05ab 100644
--- a/generator/c.ml
+++ b/generator/c.ml
@@ -1658,9 +1658,9 @@ and generate_client_actions hash () =
     let args_passed_to_daemon =
       List.filter (function FileIn _ | FileOut _ -> false | _ -> true)
         args in
-    (match args_passed_to_daemon with
-    | [] -> ()
-    | _ -> pr "  struct guestfs_%s_args args;\n" name
+    (match args_passed_to_daemon, optargs with
+    | [], [] -> ()
+    | _, _ -> pr "  struct guestfs_%s_args args;\n" name
     );
 
     pr "  guestfs_message_header hdr;\n";
-- 
1.9.3




More information about the Libguestfs mailing list