[Libguestfs] [PATCH 1/2] lib: Allow the COMPILE_REGEXP macro to be used everywhere.

[Pino Toscano]

On Tuesday 23 February 2016 10:41:06 Richard W.M. Jones wrote:
> On Tue, Feb 23, 2016 at 11:35:00AM +0100, Pino Toscano wrote:
> > On Tuesday 23 February 2016 09:17:42 Richard W.M. Jones wrote:
> > > Since the daemon links to pcre and use regular expressions, and since
> > > the COMPILE_REGEXP macro doesn't depend on any aspects of the
> > > library-side code (eg. the guestfs_h handle etc), we can allow the
> > > daemon to use the COMPILE_REGEXP macro.  Move the macro to
> > > "guestfs-internal-all.h" to permit this.
> > > ---
> > 
> > LGTM -- would you please move the <pcre.h> include from
> > guestfs-internal.h to guestfs-internal-all.h as well?
> 
> Good point, although maybe it's better not to include <pcre.h>
> everywhere and instead just include it in the C files where it is
> needed?

Even better, it seems only few sources deal with regexps.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160223/b4f36b5a/attachment.sig>