[Libguestfs] [PATCH 3/3] src: print contents of structs and struct lists on tracing

[Richard W.M. Jones]

On Wed, Feb 24, 2016 at 01:52:04PM +0100, Pino Toscano wrote:
> It eases the debugging, instead of getting just the name of the struct
> returned.

The series is fine, so ACK.  Definitely improves the trace output :-)

A few things that would be good though:

 - Export the functions through the public API.  We already have
   functions to copy structs (eg. guestfs_copy_application,
   guestfs_copy_application_list).

 - Provide another function for printing lists of structs too, so you
   don't need the loop for RStructList.

 - With those two changes, you can get rid of the internal
   structs-print.h header.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top