[Libguestfs] [PATCH] v2v: ovf: Add virtio-rng and memory balloon device

[Pino Toscano]

On Thursday, 6 April 2017 22:53:08 CEST Tomáš Golembiovský wrote:
> This affects -o rhv and -o vdsm.
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> ---

Looks mostly good.

>  v2v/create_ovf.ml | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml
> index cfca63452..03df7f934 100644
> --- a/v2v/create_ovf.ml
> +++ b/v2v/create_ovf.ml
> @@ -390,6 +390,29 @@ let rec create_ovf source targets guestcaps inspect
>          ]
>        ];
>  
> +      (* Add the miscellaneous KVM devices. *)
> +      if guestcaps.gcaps_virtio_rng then
> +        append virtual_hardware_section_items [
> +          e "Item" [] [
> +            e "rasd:Description" [] [PCData "RNG Device"];

Could it be rasd:Caption here?

> +            e "rasd:InstanceId" [] [PCData (uuidgen ())];
> +            e "rasd:ResourceType" [] [PCData "0"];
> +            e "Type" [] [PCData "rng"];
> +            e "Device" [] [PCData "virtio"];
> +          ]
> +        ];
> +      if guestcaps.gcaps_virtio_balloon then
> +        append virtual_hardware_section_items [
> +          e "Item" [] [
> +            e "rasd:Description" [] [PCData "Memory Ballooning Device"];

Ditto.

> +            e "rasd:InstanceId" [] [PCData (uuidgen ())];
> +            e "rasd:ResourceType" [] [PCData "0"];
> +            e "Type" [] [PCData "balloon"];
> +            e "Device" [] [PCData "memballoon"];
> +          ]
> +        ];
> +
> +

One extra empty line.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20170407/9ce71f17/attachment.sig>