[Libguestfs] [PATCH v3 0/4] file: Zero for block devices and older file systems

Nir Soffer nirsof at gmail.com
Sat Aug 18 22:13:04 UTC 2018


This version addresses some of the comments on v2.

Changes since v2:
- file_zero: Add missing space in function call
- is_aligned: Assert that align is indeed a power of 2
- Spelling in commit message

Not changed:
- Eric commented that spacing was off:
  https://www.redhat.com/archives/libguestfs/2018-August/msg00113.html
  but I could not find anything wrong.
- Eric asked if ioctl.h will cause grief on BSD compilation:
  https://www.redhat.com/archives/libguestfs/2018-August/msg00116.html
  I tested with FreeBSD 11.0 and 10.3 and there is no issue.
  I also look at NetBSD and OpenBSD source, and in alll ioctl()
  is defined in ioctl.h.

v2 was here:
https://www.redhat.com/archives/libguestfs/2018-August/msg00041.html

Nir Soffer (4):
  file: Avoid unsupported fallocate() calls
  file: Support zero without ZERO_RANGE
  common: Add isaligned helper module
  file: Zero for block devices on old kernels

 common/include/isaligned.h |  51 +++++++++++
 plugins/file/Makefile.am   |   3 +-
 plugins/file/file.c        | 182 +++++++++++++++++++++++++++++--------
 3 files changed, 197 insertions(+), 39 deletions(-)
 create mode 100644 common/include/isaligned.h

-- 
2.17.1




More information about the Libguestfs mailing list