[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH libnbd] generator: Move first_version fields to a single table.



On Thu, Sep 05, 2019 at 08:02:34AM -0500, Eric Blake wrote:
> On 9/5/19 6:56 AM, Richard W.M. Jones wrote:
> > See discussion in this and following messages:
> > https://www.redhat.com/archives/libguestfs/2019-September/msg00020.html
> > ---
> >  generator/generator | 131 ++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 121 insertions(+), 10 deletions(-)
> > 
> 
> > +let first_version = [
> > +  "set_debug", (1, 0);
> > +  "get_debug", (1, 0);
> > +  "set_debug_callback", (1, 0);
> > +  "clear_debug_callback", (1, 0);
> > +  "set_handle_name", (1, 0);
> > +  "get_handle_name", (1, 0);
> > +  "set_export_name", (1, 0);
> > +  "get_export_name", (1, 0);
> > +  "set_tls", (1, 0);
> > +  "get_tls", (1, 0);
> > +  "set_tls_certificates", (1, 0);
> > +  (*"get_tls_certificates", (1, 0);*)
> 
> If we ever do implement this (and any other commented out for various
> reasons), it won't be a 1.0 version...
> 
> > +
> > +  (* Added in 1.1 development series. *)
> > +  "can_fast_zero", (1, 2);
> 
> ..so maybe it's better to sink the commented future APIs to the bottom?

Good point :-)

I'll move these to the end of the list with a comment.

Thanks,
Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]