[Libosinfo] [PATCH] win7: Generalize volume-id for professional

Christophe Fergeau cfergeau at redhat.com
Thu Apr 24 08:13:53 UTC 2014



> Generalize volume-id to include 'N SP1' variant.

More descriptive log would have been nice, I had to stare at the diff for a bit to make sense of it :(

> ---
> 
> Pushed under trivial rule.
> 
>  data/oses/windows.xml.in                           |  2 +-
>  ...rofessional_n_with_sp1_x64_dvd_u_677207.iso.txt | 29
>  ++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 1 deletion(-)
>  create mode 100644
>  test/isodata/windows/win7/en_windows_7_professional_n_with_sp1_x64_dvd_u_677207.iso.txt

The test file has _x64_ in its name..

> 
> diff --git a/data/oses/windows.xml.in b/data/oses/windows.xml.in
> index 39d5b55..19dc349 100644
> --- a/data/oses/windows.xml.in
> +++ b/data/oses/windows.xml.in
> @@ -769,7 +769,7 @@
>      <media arch="i686" installer-reboots="2">

.. but you added this to the "i686" section.

>        <variant id="professional"/>
>        <iso>
> -        <volume-id>(GSP1RMCNPRFRER|GSP1RMCPRFRER|GSP1RMCPRVOL)_</volume-id>
> +
> <volume-id>(GSP1RMCNPRFRER|GSP1RMCN*PRX*FRER|GSP1RMCPRVOL)_</volume-id>

I think The 'X' bit here is what indicates whether we have a 32/64 bit ISO
'?' instead of '*' would have been enough.

Christophe




More information about the Libosinfo mailing list