[Libosinfo] [PATCH 1/5] osinfo_loader: don't wrap return value with parentheses

Christophe Fergeau cfergeau at redhat.com
Wed Jun 4 10:04:15 UTC 2014


ACK


On Wed, Jun 04, 2014 at 11:50:53AM +0200, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  osinfo/osinfo_loader.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
> index aa5e48f..685352b 100644
> --- a/osinfo/osinfo_loader.c
> +++ b/osinfo/osinfo_loader.c
> @@ -138,16 +138,16 @@ osinfo_loader_nodeset(const char *xpath,
>      obj = xmlXPathEval(BAD_CAST xpath, ctxt);
>      ctxt->node = relnode;
>      if (obj == NULL)
> -        return(0);
> +        return 0;
>      if (obj->type != XPATH_NODESET) {
>          g_set_error(err, g_quark_from_static_string("libosinfo"), 0,
>                      _("Expected a nodeset in XPath query %s"), xpath);
>          xmlXPathFreeObject(obj);
> -        return (-1);
> +        return -1;
>      }
>      if ((obj->nodesetval == NULL)  || (obj->nodesetval->nodeNr < 0)) {
>          xmlXPathFreeObject(obj);
> -        return (0);
> +        return 0;
>      }
>  
>      ret = obj->nodesetval->nodeNr;
> @@ -157,7 +157,7 @@ osinfo_loader_nodeset(const char *xpath,
>                 ret * sizeof(xmlNodePtr));
>      }
>      xmlXPathFreeObject(obj);
> -    return (ret);
> +    return ret;
>  }
>  
>  static gchar *
> -- 
> 1.9.3
> 
> _______________________________________________
> Libosinfo mailing list
> Libosinfo at redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libosinfo/attachments/20140604/e083d82c/attachment.sig>


More information about the Libosinfo mailing list