[Libosinfo] [PATCH 2/3] install-script: Add needs-internet-connection prop

[Zeeshan Ali (Khattak)]

* I think 'needs-internet' is sufficient and will help in not creating
way loo long identifiers in C. :)
* You are not adding a prop here. Please see commit log of
526fa3f39344f2177bee00add89ee7c5042701c2 if you'd like to have logs of
similar patches, consistent. Otherwise just s/prop/param/

On Fri, Jun 20, 2014 at 7:29 PM, Lasse Schuirmann
<lasse.schuirmann at gmail.com> wrote:
> ---
>  data/schemas/libosinfo.rng     |  5 +++++
>  osinfo/libosinfo.syms          | 10 ++++------
>  osinfo/osinfo_install_script.c |  8 ++++++++
>  osinfo/osinfo_install_script.h |  3 +++
>  osinfo/osinfo_loader.c         |  1 +
>  5 files changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/data/schemas/libosinfo.rng b/data/schemas/libosinfo.rng
> index 4f4edac..07defbd 100644
> --- a/data/schemas/libosinfo.rng
> +++ b/data/schemas/libosinfo.rng
> @@ -597,6 +597,11 @@
>            </element>
>          </optional>
>          <optional>
> +          <element name='needs-internet-connection'>
> +            <ref name='bool'/>
> +          </element>
> +        </optional>
> +        <optional>
>            <element name='can-pre-install-drivers'>
>              <ref name='bool'/>
>            </element>
> diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
> index abcc8bb..b387a21 100644
> --- a/osinfo/libosinfo.syms
> +++ b/osinfo/libosinfo.syms
> @@ -500,11 +500,9 @@ LIBOSINFO_0.2.10 {
>         osinfo_install_script_injection_method_get_type;
>  } LIBOSINFO_0.2.9;
>
> -/* Symbols in next release...
> -
> -  LIBOSINFO_0.0.2 {
> +/* Symbols in next release... */
> +  LIBOSINFO_0.2.11 {
>      global:
> +       osinfo_install_script_get_needs_internet_connection;
> +  } LIBOSINFO_0.2.10;
>
> -  } LIBOSINFO_0.0.1;
> -
> -*/

We always keep this commented out part for future versions. Just keep
this once and add 0.2.11 section above it.

> +gboolean osinfo_install_script_get_needs_internet_connection(OsinfoInstallScript *script)
> +{

Lets add some docs here.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/