[Libosinfo] [PATCH 1/2] win7, winxp, installer: 'ComputerName' must be <= 15 characters

Christophe Fergeau cfergeau at redhat.com
Wed May 14 14:09:52 UTC 2014


On Tue, May 13, 2014 at 12:50:28PM +0100, Zeeshan Ali (Khattak) wrote:
> > I'm also not sure substring will do the right thing with
> > non-ASCII characters, which are potentially encoded as multiple bytes
> > (the limit is 15 bytes, not 15 chars).
> 
> That is true. Either I go work on my XSLT-foo and enforce this or we
> can just document this in set_hostname. Reading this, I'd go for the
> latter as non-ASCII won't be acceptable on other OSs either:
> 
> https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names

Having some function which would be able to validate install script
parameters, and report an error if the parameter does not fit the
constraints for the current install script would probably be very
useful. I'm not exactly sure how this could be done though :(

Christophe




More information about the Libosinfo mailing list