[Libosinfo] [libosinfo PATCH v3 1/5] install-script: Add _(get|set)_preferred_injection_method()

[Daniel P. Berrangé]

On Thu, Dec 20, 2018 at 09:25:03AM +0100, Fabiano Fidêncio wrote:
> Those new methods are going to be used to tell the install-scripts
> whether the injection-method that's going to be used is. We have to do
> so as the command-line may be different depending on the
> injection-method used, for example:
> - fedora using cdrom, disk or floppy: ks=hd:/(vda|sda)/fedora.ks
> - fedora using initrd: ks=file:/fedora.ks
> 
> It's important to mention that although the methods are taking GFlags,
> those are treated as GEnum and only one value is expected to be set, as
> mentioned in the documentation.
> 
> Also, mind that the usage of osinfo_entity_set_param() to store the
> nick of the OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_* is intentional as
> the nick is exactly what's going to be used in the install-scripts to
> generate the proper command-line.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  osinfo/libosinfo.syms          |  3 ++
>  osinfo/osinfo_install_script.c | 89 ++++++++++++++++++++++++++++++++++
>  osinfo/osinfo_install_script.h |  4 ++
>  3 files changed, 96 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|