[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] Re: Virtual CPU functions



On Wed, Aug 02, 2006 at 09:48:35AM +0200, Philippe Berthault wrote:
> 
> >Just a C implem nitpick, but that can lead to interesting debugging
> >sessions (I think I got beaten by that a couple of time).
> >  Nowhere the compiler can guess that you're accessing a 2 dimentional 
> >  array
> >with a row of length domInfo.nrVirtCpu, it's a one dimension array so I
> >think cpuMaps[vcpu][byteCpu] is equivalent to cpuMaps[vcpu + byteCpu] there
> >and unless I misunderstood both case that won't work as expected. This is
> >also why I suggested a macro this can of code is easy to get wrong.
> >
> >Daniel
> OK, you are right. ;-)

  That happens, sometimes, when it's clearly not the case don't hesistate
to yell a bit because I can be stubborn :-)

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]