Re: [Libvir] Updated patch for hvm guests

[Daniel Veillard <veillard redhat com>]

 Hi Jim,

 hope you enjoyed your vacations :-)

On Fri, Jun 30, 2006 at 04:02:54PM -0600, Jim Fehlig wrote:
> Attached is an updated patch providing some support for HVM guests.  I 
> have tested listing info on running guests and creating guests.  cdrom 
> support for HVM guests still needs some work, as does graphics options.  
> Guests using graphics type 'sdl' still need some work.  Using type 'vnc' 
> is functional, but you must then manually use e.g. "vncviewer 
> localhost:<dom_id>" to view.

  Okay, I have been looking at it in the last couple of days
I have changed the XML description slightly in the os part:
  - instead stating that hvmloader is a kernel, well I used a 
    <loader>/usr/lib/xen/boot/hvmloader</loader> 
    loader tag intead, contrary to the non HVM version the kernel 
    doesn't point to a kernel file, so better rename to what it actually is
  - second the device_model is really a device emulator, better placed
    in the <devices> section so it is moved there as
    <emulator>/usr/lib/xen/bin/qemu-dm</emulator>
I have made changes to the XML conversion code to reflect this, I will commit
whithin one hour or two. Attached is one example of the XML for HVM.

> I've also included a patch that backs out some optimizations done 
> xend_internal.c.  There is a bug in xend (from testing - I think Anthony 
> fixed it and patch got applied to unstable) that does not close the 
> connection after initial create op causing libvirt to block 
> indefinitely.  Backing out the optimizations allowed me to use the hvm 
> patch on _testing branch of xen.  I've included it for anyone else that 
> may want to experiment with the hvm patch on _testing xen.

  Okay I applied it, it is clearly identified and we can revert it later,
more likely this current code will die slowly when converted to XML-RPC.

> Finally, the attached archive contains: 1. a sample xml input file for 
> hvm guest, 2. corresponding s-expr sent to xend, and 3. s-expr returned 
> from xend when getting info on the running guest.

  Thanks, that helped a lot :-)

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

<domain type='xen' id='3'>
  <name>fv0</name>
  <uuid>4dea22b31d52d8f32516782e98ab3fa0</uuid>
  <os>
    <type>hvm</type>
    <loader>/usr/lib/xen/boot/hvmloader</loader>
    <boot dev='hda'/>
  </os>
  <memory>524288</memory>
  <vcpu>1</vcpu>
  <on_poweroff>destroy</on_poweroff>
  <on_reboot>restart</on_reboot>
  <on_crash>restart</on_crash>
  <devices>
    <emulator>/usr/lib/xen/bin/qemu-dm</emulator>
    <interface type='bridge'>
      <source bridge='xenbr0'/>
      <mac address='00:16:3e:5d:c7:9e'/>
      <script path='vif-bridge'/>
    </interface>
    <disk type='file'>
      <source file='/root/fv0'/>
      <target dev='ioemu:hda'/>
    </disk>
    <graphics type='vnc'/>
  </devices>
</domain>