[Libvir] Updated patch for hvm guests

[Daniel P. Berrange]

On Tue, Jul 11, 2006 at 08:54:50AM -0400, Daniel Veillard wrote:
> On Tue, Jul 11, 2006 at 01:47:05PM +0100, Daniel P. Berrange wrote:
> > On Mon, Jul 10, 2006 at 04:27:55PM -0400, Daniel Veillard wrote:
> > >   Hum, so you would like to automatically default it ? I still think
> > > <graphics type='vnc'/> should be an accepted input meaning "whatever is
> > > the default", but fine to add it back on any dump. Would that suit you ?
> > 
> > I don't want to have any knowledge about 'defaults' in my app because I
> > know this will break in the future :-(
> 
>   You don't have to rely on defaults. Either you write the XML, then you
> put the port and you are fine, and if you read the XML then we garantee
> you get the port associated. So I don't see how my suggestion would break
> your requirement.

Ahh, I see what you mean - yes, having it optional when writing XML is
fine, if reading XML is always guarenteed to include port.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|