[Libvir] Patch for include file syntax

Daniel P. Berrange berrange at redhat.com
Thu Mar 23 22:06:45 UTC 2006


When doing an out-of-tree build of code which uses virterror.h,
one gets a build failure, because when deployed virterror.h lives 
in subdir of the include directory rather than the top level

In file included from Virt.xs:25:
/usr/include/libvirt/virterror.h:17:21: error: libvirt.h: No such file or directory
In file included from Virt.xs:25:
/usr/include/libvirt/virterror.h:62: error: expected specifier-qualifier-list before ‘virConnectPtr’
/usr/include/libvirt/virterror.h:122: error: expected ‘)’ before ‘conn’
/usr/include/libvirt/virterror.h:123: error: expected ‘)’ before ‘conn’
/usr/include/libvirt/virterror.h:129: error: expected ‘)’ before ‘conn’
/usr/include/libvirt/virterror.h:132: error: expected ‘)’ before ‘conn’


This is fixable by making virterror.h use "..." instead of <...> to
include libvirt.h. Attaching a patch to fix this

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 
-------------- next part --------------
# HG changeset patch
# User "Daniel P. Berrange <berrange at redhat.com>"
# Node ID 7e080d63ac84ab4504d8239d543e384dc0170b62
# Parent  6a2b3295866428631f2259207f5f5a3da9bfb7f5
Fixed include files when placed into /usr/include/libvirt/ subdir

diff -r 6a2b32958664 -r 7e080d63ac84 include/virterror.h
--- a/include/virterror.h	Thu Mar 23 16:53:26 2006 -0500
+++ b/include/virterror.h	Thu Mar 23 16:53:55 2006 -0500
@@ -14,7 +14,7 @@
 #ifndef __VIR_VIRERR_H__
 #define __VIR_VIRERR_H__
 
-#include <libvirt.h>
+#include "libvirt.h"
 
 #ifdef __cplusplus
 extern "C" {


More information about the libvir-list mailing list