[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH 1/6] Inactive domain support: new virConf APIs



On Wed, Nov 15, 2006 at 02:15:07AM +0000, Daniel P. Berrange wrote:
> 
> The attached patch adds two new APIs to the virConf object needed for
> creating new inactive domains:
> 
>   virConfNew
>   virConfSetValue
> 
> Docs for these methods are inline with the patch. The semantics of the
> virConfSetValue method are changed based on previous feedback - the
> 'value' object passed in is now always owned by the vifConf object upon
> return - even upon failure. This actually simplified the calling code
> quite alot too.

  I think I reviewed this already in September, I could not spot anything
wrong, this is infrastructure and APIs are good so please push it :-)

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]