[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH 5/6] Inactive domain support: pygrub / framebuffer fix



On Wed, Nov 15, 2006 at 05:15:31AM -0500, Daniel Veillard wrote:
> On Wed, Nov 15, 2006 at 02:27:53AM +0000, Daniel P. Berrange wrote:
> > With the paravirtualized framebuffer, the 'vnc' related options are all 
> > within the  (image (linux  ...)) bit of the S-Expression. When using the
> > pygrub bootloader though, there is no (image) block in the SXPR at all.
> > This patch changes this, so that if a bootloader is used, then we still
> > generate an (image) block containing only the VNC related bits.
> > 
> > This patch is dependant on a corresponding fix to XenD server - I'm also
> > attaching this patch here for conveinance. It appears as if the paravirt
> > framebuffer configuration will change significantly before it is merged
> > upstream in xen-devel, so I don't anticpate the attached patch being
> > merged in libvirt CVS. Instead it'll probably live in the Fedora / RHEL
> > RPM spec files as a patch. I include it here merely for completeness
> 
>   Okay, I just note the second patch is not contextual. It's too bad
> we can't extract whether xend has the feature, but well ...

Well, one option is to just send this style SXPR regardless and not
even bother to try and detect if my patch is enabled in xend - pushing
the failure from libvirt space, to xend space. 

We'll be able to detect the new style paravirt framebuffer code in xen
because they'll hopefully update  xend_config_version  counter when
merging it.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]