[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH 1/6] Inactive domain support: new virConf APIs



On Wed, Nov 15, 2006 at 04:32:21AM -0500, Daniel Veillard wrote:
> On Wed, Nov 15, 2006 at 02:15:07AM +0000, Daniel P. Berrange wrote:
> > 
> > The attached patch adds two new APIs to the virConf object needed for
> > creating new inactive domains:
> > 
> >   virConfNew
> >   virConfSetValue
> > 
> > Docs for these methods are inline with the patch. The semantics of the
> > virConfSetValue method are changed based on previous feedback - the
> > 'value' object passed in is now always owned by the vifConf object upon
> > return - even upon failure. This actually simplified the calling code
> > quite alot too.
> 
>   I think I reviewed this already in September, I could not spot anything
> wrong, this is infrastructure and APIs are good so please push it :-)

Now committed.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]