[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [Patch 3/4]: Xen inactive domains: stop xend/xs/xen using inactive domains



On Mon, Sep 04, 2006 at 05:22:07AM -0400, Daniel Veillard wrote:
> On Mon, Sep 04, 2006 at 01:37:29AM +0100, Daniel P. Berrange wrote:
> >  static int
> >  xend_get(virConnectPtr xend, const char *path,
> > -         char *content, size_t n_content)
> > +         char *content, size_t n_content, int quiet404s)
> 
>   hum following comment missing from xend_get()
> 
>  * @quiet404s: if set then do not error on 404 for non-exitent domains
> 
> > @@ -648,7 +651,7 @@
> >   * Returns a parsed S-Expression in case of success, NULL in case of failure
> >   */
> >  static struct sexpr *
> > -sexpr_get(virConnectPtr xend, const char *fmt, ...)
> > +sexpr_get(virConnectPtr xend, int quiet404s, const char *fmt, ...)
> 
>   same missing comment.
> 
>   Looks fine, go ahead!

ok, will fix missing comments & commit.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]