[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] Fix substitution of QEMUD_PID_FILE



On Tue, 2007-04-03 at 11:40 +0100, Richard W.M. Jones wrote:

> Use AC_SUBST instead of AC_DEFINE because we want autoconf to
> substitute 
> the value into the Makefile, not into config.h.  Then add 
> @QEMUD_PID_FILE@ to CFLAGS.

	Sounds sane ...

	Bear in mind, though, that ${prefix}/var is the default for
$localstatedir ... but all Fedora packages would be built with
--localstatedir=/var, just like --sysconfdir=/etc

	I don't think you see the problem if you pass a value for
--localstatedir

> +       -DQEMUD_PID_FILE="\"@QEMUD_PID_FILE \""

	Use $(QEMU_PID_FILE)

Chers,
Mark.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]