[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] xend_internal reads in bytes?



On Tue, Apr 03, 2007 at 09:29:22AM +0100, Richard W.M. Jones wrote:
> [Just an observation here - I'm busy with something else but may be able 
> to take a closer look at this later.]
> 
> Not only does xend_internal open a new connection for every HTTP request 
> it makes, but it also reads the headers in as single bytes (but the body 
> as a whole, presumably once it has Content-Length):

I fixed this previously, but IIRC we had to back out my fix due to a horrible
bug in XenD. It was something like XenD would leak the socket into the QEMU
device model, so if you did a big 8000 byte read we'd just block waiting on
end of file which never came. Any Xen 3.0.3 or newer has a fix.

We could probably re-instate my original fix 

    cvs diff -r 1.18 -r 1.19 -up xend_internal.c

Perhaps making the code conditional on xend_config_version >= 2 to avoid
tickling the bugon 3.0.2

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]