[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH][RFC] shows scheduler information



On Wed, Apr 11, 2007 at 02:22:43PM +0100, Richard W.M. Jones wrote:
> Please don't return static strings from functions.  It does not work 
> well in the remote case.
> 
> I don't like the dynamic typing going on in this patch altogether, but 
> with the above statically allocated strings, I think this patch should 
> not go in in its current form.

  I'm not enthusiastic about the dynamic typing either, but the 
const char * return value is relatively easilly fixable, just need to 
strdup() the value and change the API to char * and document that
the return value should be freed.
  Would you still be against with such a change ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]