[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Check for /usr/bin/qemu* binaries before starting guest



On Sun, Apr 15, 2007 at 09:59:35PM +0100, Daniel P. Berrange wrote:
> The attached patch fixes two issues
> 
>  - It explicitly checks to see if the requested /usr/bin/qemu* binary
>    actually exists before fork()/exec()'ing it. While its technically
>    possible to catch the execve() failure of ENOENT, its a real pain to
>    feed this error back to the qemu daemon because we're in a sub-process
>    at that point. The obvious & easy solution is to thus check to see if
>    the binary exists before trying to fork.
> 
>  - It only passes the -no-kqemu flag if we're running matching arch to
>    the host. Previously it would pass the -no-kqemu flag even if running
>    an x86_64 guest on i686 platform - QEMU then exited with error because
>    the -no-kqemu flag is not recognised on x86_64 when running on i686 host.

  Looking purely at the code this looks fine to me,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]