[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] check the file name for --log



Hi, Dan

Then This kind of Warning is acceptable?

Thanks
Atsushi SAKAI


"Daniel P. Berrange" <berrange redhat com> wrote:

> On Tue, Jul 31, 2007 at 08:12:56PM +0900, Atsushi SAKAI wrote:
> > Hi,
> > 
> > This patch fixes the trouble if execute virsh with 
> > virsh --log --debug.
> > In this case FILE "--debug" is generated and 
> > --debug is off. 
> > 
> > This patch treat as error return 
> > if it uses the hyphen "-" at the head of log file name.
> 
> NACK. The code is already doing exactly what the user asked. The --log
> flag takes an argument and you are supplied --debug as that argument.
> Therefore it creates the file --debug. This is fine.
> 
> Dan.
> -- 
> |=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
> |=-           Perl modules: http://search.cpan.org/~danberr/              -=|
> |=-               Projects: http://freshmeat.net/~danielpb/               -=|
> |=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Attachment: virsh_logfilename_warning.patch
Description: Binary data


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]