[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] [PATCH] A variety of fixes for Debian, old versions of GnuTLS



On Tue, Aug 07, 2007 at 12:56:39PM +0100, Richard W.M. Jones wrote:
> Attached is a patch to get libvirt working on Debian/stable again.
> 
> (1) Add ./configure option --disable-stack-protector.  The stack 
> protector feature is still enabled by default, but it causes no end of 
> problems when compiling on Debian systems, apparently because of bugs in 
> their gcc.  So Debian users would be well advised to try disabling it if 
> they have problems building.
> 
> (2) Adds support for GnuTLS 1.0.x by detecting this version and enabling 
> some simple compatibility macros.
> 
> (3) In qemudDispatchClientEvent, a prototype shadowed a global function 
> name.  A simple name change to a parameter fixes it.
> 
> (4) Debian (and likely non-Linux systems also) don't have the 
> SIOCBRADDBR and related ioctls.  If these are missing, then I've changed 
> this to runtime errors.  This means that these systems won't be able to 
> start the network daemon, but other (non-network) features of libvirt 
> continue to work.
> 
> (5) Removed a warning in src/qemu_conf.c.
> 
> Rich.
> 
> PS. You need to drop the file gnutls_1_0_compat.h into src/ 
> subdirectory.  Sorry this file isn't in the proper patch but I don't 
> have write access to CVS from the testing machine.

  Do we really need to have this as a separate file ? I'm wondering if those
macros can't be merged into some kind of exsting internal header.
But yeah that looks fine to me and fairly useful, we should try to get this
fixed as earlier as possible,

  thanks !

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]