[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libvir] PATCH: Fix virtual neworks with xm driver



On Fri, Aug 10, 2007 at 04:36:25PM +0100, Daniel P. Berrange wrote:
> The virtual networks stuff was never added to the xm driver for Xen 3.0.3
> or earlier. This means that if adding a virtual network the bridge device
> won't get defined in the config. This patch addreses this, and also fixes
> a tiny mem leak in the equivalent code in the xend driver.

Looks fine, I'm just surprised by

> @@ -1694,9 +1707,12 @@ static char *xenXMParseXMLVif(xmlNodePtr
>          if (typ == 0) {
>              strcat(buf, ",bridge=");
>              strcat(buf, (const char*)source);
> -        } else {
> -            strcat(buf, ",mac=");
> +        } else if (typ == 1) {
> +            strcat(buf, ",dev=");
>              strcat(buf, (const char*)source);
> +        } else {
> +            strcat(buf, ",bridge=");
> +            strcat(buf, bridge);
>          }
>      }

  So we never emit the mac definition anymore ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]